fix(Android): missing content when using flex for formsheet contents #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/missing-content-when-using-flex
branch
from
5394570 to
f95d114
Compare
kkafar
force-pushed
the
@kkafar/missing-content-when-using-flex
branch
from
bdea50b to
cd15d0f
Compare
Merged
1 task
kkafar
added a commit
that referenced
this pull request
Mar 10, 2025
…& apply appropriate styles (#2762) ## Description I've made a small change in v5 code in #2748, however due to my overlook it introduced a regression in native-stack v5. Since it is a quick fix I'm patching it. Basically I've parsed & transformed `sheetAllowedDetents` value in `RouteView`, **before** passing it to `MaybeNestedStack`, where I've checked for `sheetAllowedDetents === 'fitToContents'`, which could not be true, because in such case it has been transformed to `[-1]` literal in `RouteView`. Only the latest 4.10.0-beta.0 & beta.1 versions are affected. ## Changes Removed `sheetAllowedDetents` prop value transformation in `RouteView` since `Screen` component handles it nicely internally. ## Test code and steps to reproduce `TestFormSheet`, but you need to run it using `createNativeStackNavigator` from `react-native-screens/native-stack`. Don't forget to change the `presentation` prop to `stackPresentation`, when changing to v5. ## Checklist - [ ] Ensured that CI passes
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the styles applied to the content in screens with
formSheetpresentation.Currently when using
flex: 1on the content of the sheet it might cause the content to disappear. This PR mitigates that.Changes
When not in
fitToContentsmode we applyflex: 1to content wrapper.Test code and steps to reproduce
TestFormSheet- notice that the contents hasflex: 1and it displays correctly.Checklist