feat(iOS): add experimental support for scrollview header when using formsheet #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given numerous feature requests & the frequent need to have header above the scrollview in sheet this PR adds this possibility.
Please see
TestFormSheetfor example implementation.Note that this PR enables header by handling special case when there is exactly one view rendered directly under sheet at index 0 (and scroll view on index 1). Again - see example ☝🏻
Changes
We're now detecting special case inside content wrapper: scroll view at index 0 or header at 0 & scrollview at 1. We then adjust the layout manually. If these cases are not detected we fallback to previous behaviour.
Test code and steps to reproduce
Enhanced
TestFormSheetto allow for testing this.Checklist