feat(iOS): make fitToContents sheet size react to dynamic content
#2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just came here to say: amazing, exactly what I am looking for. Hopefully for both iOS and Android |
2 tasks
|
Superseded by #2877 |
kligarski
added a commit
that referenced
this pull request
May 5, 2025
…#2877) ## Description Allows `fitToContents` sheet's height to adapt to dynamic content on iOS. `contentWrapper:(RNSScreenContentWrapper *)contentWrapper receivedReactFrame:(CGRect)reactFrame` receives many frames, some of them contain the same dimensions. Calling `[self setAllowedDetentsForSheet:sheetController to:detents animate:YES]` mutliple times, even with the same `detents`, causes visual glitches (dimming behing formSheet on iPhone/iPad and header on iPad have very odd-looking animations). Before, we would set `_didSetSheetAllowedDetentsOnController` to `YES` after setting detents for the first time and then ignore all incoming frames - including those with new height after content changed its height. Now, we remember frame height we received, and when we receive a new frame, we compare new height to the previous value. If it is different, we update detents using `setAllowedDetentsForSheet`. Supersedes #2741. Fixes #2688. ## Changes - replace boolean property `_didSetSheetAllowedDetentsOnController` with float `_sheetFrameHeight` - add `Test2877` test screen ## Screenshots / GIFs | Before | After | | ------ | ------ | | <video src="https://github.com/user-attachments/assets/52895e55-483d-4766-bca2-7550757f1868" alt="before" /> | <video src="https://github.com/user-attachments/assets/d3bf33c0-5186-40e5-9b41-77aa31936cec" alt="after" /> | ## Test code and steps to reproduce Enter `Test2877` screen and open form sheet. Its height should adapt to displayed content every second. ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP
Changes
Test code and steps to reproduce
Checklist