chore(CI): run e2e tests on Fabric #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e tests on Fabric. We need those!
Currently the tests are duplicated for the sake of one single test on Android that fails only on CI...
iOS tests fail also locally - most likely we have some discrepancies between old & new architecture. Needs to be investigated, hover I do not treat it as a blocker, since this PR aims to setup these tests, fixing them will be handled separately.
Changes
Also:
DETOX_AVD_NAME(name avd that detox should use for locally running tests, if not set the scripts will try to choose somethign from list of available devices)Test code and steps to reproduce
CI +
yarn build-e2e-{android,ios} && yarn test-e2e-{android,ios}Checklist