fix(iOS): look through whole ancestor chain when looking for screenview from content wrapper #2683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #2670 I've added a check that logged RN error in case
contentWrapper.reactSuperview
is not aRNSScreenView
.Now I got reports (but no reproduction :/) from two independent sources that this error is triggered pretty often,
which is unexpected from my perspective. I blindly blame view flattening / usage of legacy navigators but can not be sure.
This PR is an attempt to patch this behaviour.
Changes
contentWrapper now searches whole view ancestor chain before logging an error.
Test code and steps to reproduce
No reproducer :/
Checklist