fix: point to existing symbol names in ios.componentProvider
#2583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
ios.componentProvider
kligarski
pushed a commit
that referenced
this pull request
Feb 25, 2025
## Description #2567 introduced `ios.componentProvider` field to package definition - and that's fine, but we're pointing to wrong names there. ## Changes Updated the names to existing symbol names. ## Test code and steps to reproduce This caused runtime errors when running the app on 0.77. I need this commit for the #2581 (0.77 support) ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Updated documentation: <!-- For adding new props to native-stack --> - [ ] https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx - [ ] https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx - [ ] Ensured that CI passes
1 task
kligarski
added a commit
that referenced
this pull request
Feb 26, 2025
## Description Adding support for `[email protected]`. **RN version of the library still left at `0.72.4`.** ## Changes - adjusted example apps on both architectures with changes from upgrade helper, - added codegen `ios.componentProvider` - #2567 - #2583 - removed providers that are not present in this version (RNSScreenFooter, RNSScreenContentWrapper) (ef2c7a4) - bumped dependencies: - `react-native-gesture-handler` to `2.22.0` - `react-native-reanimated` to `3.16.7` - `react-native-safe-area-context` to `5.1.0` - removed patches that were no longer needed - updated view manager interfaces (f968e05) - in order for this to work, **commented out codegen script** from Example/android/app/build.gradle (bf30abf), as it was overwriting correct fix -> **needs to be investigated** - fixed build issues on iOS (0f53ad1) - #2497 - adjusted to 3.x (removed unnecessary files, imports) - changed Metro config for FabricExample (ef2c7a4) ## Test code and steps to reproduce CI ## Checklist - [ ] Ensured that CI passes --------- Co-authored-by: Jakub Grzywacz <[email protected]> Co-authored-by: Kacper Kafara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2567 introduced
ios.componentProviderfield to package definition - and that's fine, but we're pointing to wrong names there.Changes
Updated the names to existing symbol names.
Test code and steps to reproduce
This caused runtime errors when running the app on 0.77. I need this commit for the #2581 (0.77 support)
Checklist