feat: don't set display: 'none' on frozen screens #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Graham Mendick <[email protected]>
WoLewicki
approved these changes
Nov 10, 2021
kacperkapusciak
deleted the
@kacperkapusciak/dont-set-display-none-on-frozen-screens
branch
7 tasks
kligarski
added a commit
that referenced
this pull request
Mar 13, 2025
…eens to work with RN 0.78 (#2778) ## Description React Native sets `display: 'none'` for frozen screens - this behavior can become an issue, if you for example press back button twice very fast on iOS - frozen screen might still be invisible. The problem and its workaround suggested by @grahammendick can be seen in issue #1207. The workaround was introduced in PR #1208. Recently, React Native 0.78 has changed the way of diffing props and the workaround stopped working. The details and a new workaround has been suggested by @grahammendick once again in issue #2753 and PR grahammendick/navigation#860. This PR introduces the suggested workaround. A big thank you to @grahammendick for figuring it out and suggesting the solution once again, appreciate it! Furthermore, the new workaround fixes a bug with back button on the screen stack header on iOS. The bug was probably introduced with the update to 0.78. The back button would disappear and then reappear after a short delay with generic "Back" label instead of the screen name. https://github.com/user-attachments/assets/a371df20-d230-4e38-8770-022b72bacb6a https://github.com/user-attachments/assets/8c3c9572-f77b-46ab-804c-d50361eeba06 Fixes #2753. ## Changes - change `display: false` to `display: null`, - change `ViewConfig` interface to allow `null` value. ## Tests Run `TestFreeze` example, click `Go to Details` twice and then click the back button in the header. The button behaves as expected, which was not the case before - the button would disappear and then reappear with a generic "Back" title. ## Checklist - [x] Updated TS types - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Suspensemechanism inreact-freezesetsdisplay: noneon a frozen screen. This sometimes results in an 'empty' screen when navigating between multiple screens at once (e.g. by using iOS back button menu).This PR prevents showing frozen screen by making the
displayproperty onviewConfig.validAttributes.stylenot valid.A detailed explanation can be found here
Thank you @grahammendick for this brilliant idea! 🙌
Fixes #1207
Test code and steps to reproduce
Test658,Test791,TestFreezeinTestsExample/projectChecklist