[Android] Crash on killed app restore

[Sroka]

Hey, I am getting a crash on current version of this lib (^1.0.0-alpha.22)

2019-06-14 13:29:35.255 27866-27866/com.gelato.Optimalprint.dev E/AndroidRuntime: FATAL EXCEPTION: main Process: com.gelato.Optimalprint.dev, PID: 27866 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.gelato.Optimalprint.dev/com.gelato.Optimalprint.MainActivity}: android.support.v4.app.Fragment$InstantiationException: Unable to instantiate fragment com.swmansion.rnscreens.Screen$ScreenFragment: calling Fragment constructor caused an exception at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2778) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856) at android.app.ActivityThread.-wrap11(Unknown Source:0) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:164) at android.app.ActivityThread.main(ActivityThread.java:6494) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807) Caused by: android.support.v4.app.Fragment$InstantiationException: Unable to instantiate fragment com.swmansion.rnscreens.Screen$ScreenFragment: calling Fragment constructor caused an exception at android.support.v4.app.Fragment.instantiate(Fragment.java:465) at android.support.v4.app.FragmentContainer.instantiate(FragmentContainer.java:50) at android.support.v4.app.FragmentState.instantiate(FragmentState.java:80) at android.support.v4.app.FragmentManagerImpl.restoreAllState(FragmentManager.java:3109) at android.support.v4.app.FragmentController.restoreAllState(FragmentController.java:158) at android.support.v4.app.FragmentActivity.onCreate(FragmentActivity.java:344) at android.support.v7.app.AppCompatActivity.onCreate(AppCompatActivity.java:85) at com.facebook.react.ReactActivity.onCreate(ReactActivity.java:51) at android.app.Activity.performCreate(Activity.java:7009) at android.app.Activity.performCreate(Activity.java:7000) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1214) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2731) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)  at android.app.ActivityThread.-wrap11(Unknown Source:0)  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)  at android.os.Handler.dispatchMessage(Handler.java:106)  at android.os.Looper.loop(Looper.java:164)  at android.app.ActivityThread.main(ActivityThread.java:6494)  at java.lang.reflect.Method.invoke(Native Method)  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)  Caused by: java.lang.reflect.InvocationTargetException at java.lang.reflect.Constructor.newInstance0(Native Method) at java.lang.reflect.Constructor.newInstance(Constructor.java:334) at android.support.v4.app.Fragment.instantiate(Fragment.java:443) at android.support.v4.app.FragmentContainer.instantiate(FragmentContainer.java:50)  at android.support.v4.app.FragmentState.instantiate(FragmentState.java:80)  at android.support.v4.app.FragmentManagerImpl.restoreAllState(FragmentManager.java:3109)  at android.support.v4.app.FragmentController.restoreAllState(FragmentController.java:158)  at android.support.v4.app.FragmentActivity.onCreate(FragmentActivity.java:344)  at android.support.v7.app.AppCompatActivity.onCreate(AppCompatActivity.java:85)  at com.facebook.react.ReactActivity.onCreate(ReactActivity.java:51)  at android.app.Activity.performCreate(Activity.java:7009)  at android.app.Activity.performCreate(Activity.java:7000)  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1214)  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2731)  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)  at android.app.ActivityThread.-wrap11(Unknown Source:0)  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)  at android.os.Handler.dispatchMessage(Handler.java:106)  at android.os.Looper.loop(Looper.java:164)  at android.app.ActivityThread.main(ActivityThread.java:6494)  at java.lang.reflect.Method.invoke(Native Method)  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)  Caused by: java.lang.IllegalStateException: Screen fragments should never be restored at com.swmansion.rnscreens.Screen$ScreenFragment.<init>(Screen.java:23) at java.lang.reflect.Constructor.newInstance0(Native Method)  at java.lang.reflect.Constructor.newInstance(Constructor.java:334)  at android.support.v4.app.Fragment.instantiate(Fragment.java:443)  at android.support.v4.app.FragmentContainer.instantiate(FragmentContainer.java:50)  at android.support.v4.app.FragmentState.instantiate(FragmentState.java:80)  at android.support.v4.app.FragmentManagerImpl.restoreAllState(FragmentManager.java:3109)  at android.support.v4.app.FragmentController.restoreAllState(FragmentController.java:158)  at android.support.v4.app.FragmentActivity.onCreate(FragmentActivity.java:344)  at android.support.v7.app.AppCompatActivity.onCreate(AppCompatActivity.java:85)  at com.facebook.react.ReactActivity.onCreate(ReactActivity.java:51)  at android.app.Activity.performCreate(Activity.java:7009)  at android.app.Activity.performCreate(Activity.java:7000)  at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1214)  at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2731)  at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2856)  at android.app.ActivityThread.-wrap11(Unknown Source:0)  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1589)  at android.os.Handler.dispatchMessage(Handler.java:106)  at android.os.Looper.loop(Looper.java:164)  at android.app.ActivityThread.main(ActivityThread.java:6494)  at java.lang.reflect.Method.invoke(Native Method)  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807) 

I guess this is happening because of this code in ScreenFragment:
public ScreenFragment() { throw new IllegalStateException("Screen fragments should never be restored"); }

It will happen to users only when the activity is killed in the background and then user tries to restore it. It is easily reproducible by setting "Don't keep Activities" in Developer options.

[grciqa]

I believe this is the same issue as #105 and #54

[m4r00p]

Any luck guys with fixing this? (screens give really big boost the app but they crashing the app each time for the given scenario... ;()

[fontesrp]

Any idea on how to solve/work-around this? I'm getting this error A LOT in my production build. Has anyone at least been able to find the line in this library that is causing the error?

Here are my dependencies:

  "dependencies": {
    "@react-native-community/async-storage": "^1.5.1",
    "@react-native-community/netinfo": "^4.1.2",
    "axios": "^0.19.0",
    "color": "^3.1.2",
    "formik": "^1.5.8",
    "himalaya": "^1.1.0",
    "qs": "^6.7.0",
    "react": "16.8.6",
    "react-native": "0.60.4",
    "react-native-awesome-card-io": "^0.8.2",
    "react-native-camera": "^3.0.0",
    "react-native-code-push": "^5.6.1",
    "react-native-fast-image": "^7.0.2",
    "react-native-fbsdk": "git+https://github.com/facebook/react-native-fbsdk.git",
    "react-native-gesture-handler": "^1.3.0",
    "react-native-google-signin": "^2.0.0",
    "react-native-reanimated": "^1.1.0",
    "react-native-screens": "^1.0.0-alpha.23",
    "react-native-sentry": "^0.43.2",
    "react-native-webview": "^5.12.1",
    "react-navigation": "^3.11.1",
    "react-redux": "^7.1.0",
    "redux": "^4.0.4",
    "redux-thunk": "^2.3.0",
    "styled-components": "^4.3.2",
    "urbanairship-react-native": "^3.1.1",
    "yup": "^0.27.0"
  }

[fontesrp]

If anyone else has this issue, I solved it by editing my MainActivity so it does not try to re-open the app's saved state:

public class MainActivity extends ReactActivity {
  @Override
  protected void onCreate(Bundle savedInstance) {
    // super.onCreate(savedInstance);
    super.onCreate(null);
  }
}

[douglasjunior]

Similar problem here reported by the Google Play Store:

Samsung Galaxy J7 Prime (on7xelte), Android 8.1

java.lang.RuntimeException: 
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2974)
  at android.app.ActivityThread.handleLaunchActivity (ActivityThread.java:3059)
  at android.app.ActivityThread.-wrap11 (Unknown Source)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1724)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loop (Looper.java:164)
  at android.app.ActivityThread.main (ActivityThread.java:7000)
  at java.lang.reflect.Method.invoke (Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:441)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1408)
Caused by: androidx.fragment.app.Fragment$InstantiationException: 
  at androidx.fragment.app.Fragment.instantiate (Fragment.java:465)
  at androidx.fragment.app.FragmentContainer.instantiate (FragmentContainer.java:50)
  at androidx.fragment.app.FragmentState.instantiate (FragmentState.java:80)
  at androidx.fragment.app.FragmentManagerImpl.restoreAllState (FragmentManager.java:3109)
  at androidx.fragment.app.FragmentController.restoreAllState (FragmentController.java:158)
  at androidx.fragment.app.FragmentActivity.onCreate (FragmentActivity.java:344)
  at androidx.appcompat.app.AppCompatActivity.onCreate (AppCompatActivity.java:85)
  at com.facebook.react.ReactActivity.onCreate (ReactActivity.java:51)
  at app.klist.mobileapp.MainActivity.onCreate (MainActivity.java:17)
  at android.app.Activity.performCreate (Activity.java:7258)
  at android.app.Activity.performCreate (Activity.java:7249)
  at android.app.Instrumentation.callActivityOnCreate (Instrumentation.java:1222)
  at android.app.ActivityThread.performLaunchActivity (ActivityThread.java:2927)
Caused by: java.lang.reflect.InvocationTargetException: 
  at java.lang.reflect.Constructor.newInstance0 (Native Method)
  at java.lang.reflect.Constructor.newInstance (Constructor.java:334)
  at androidx.fragment.app.Fragment.instantiate (Fragment.java:443)
Caused by: java.lang.IllegalStateException: 
  at com.swmansion.rnscreens.Screen$ScreenFragment.<init> (Screen.java:23)

[vikjovanov]

@douglasjunior I have the exact same error from the Google Play Console, how did you solve this problem?

[douglasjunior]

Hi @vikjovanov, sorry, I removed the react-native-screens from the projects until it became stable, I had a lot of crash problems so we decided not to insist for now.

[vikjovanov]

@douglasjunior Thank you for your answer, and do you feel a significant difference in performance or not?

[douglasjunior]

I always used "react-navigation" without this lib, I was just experimenting.

The only difference you will have would be in apps that open a very large stack of screens.

In the case of these apps you will have a RAM savings using "react-native-screens".

[vikjovanov]

@douglasjunior Ok ok ! Thanks a lot for your feedback, I'll think about it because I also have a lot of problems on Android with react-native-screens!

[kmagiera]

I believe this issue should be resolved as of the latest version 2.0.0-beta.8. I can't tell for 100% because there was no repro scenario we could use to verify but fixes for few similar crashes have been applied since alpha.22. If you can still repro this on 2.0.0-beta.8 please provide a small repro app and start a new issue or comment here and I'll reopen.

[douglasjunior]

@kmagiera Did "react-native-screens" have any versions requirements for "react-native-reanimated" or "react-native-gesture-handler"?

[kmagiera]

what do you mean by "version requirement". Those three packages are all disjoint and not directly depend on each other. There are some libraries that depend on some combination of these three but out of the box they are not coupled

[rinpatva14]

Hi @kmagiera,
Facing same issue still in version - 2.3.0.

Issue.- com.facebook.react.ReactActivity.onCreate.
Crash when app launch - Many live app user reported this issue.