feat: Add working [email protected] #8248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Oct 1, 2025
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Outdated
Show resolved
Hide resolved
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Show resolved
Hide resolved
tomekzaw
reviewed
Oct 7, 2025
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Show resolved
Hide resolved
MatiPl01
requested changes
Oct 9, 2025
MatiPl01
approved these changes
Oct 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
## Summary CI to check roby and cocoapods the macos won't pass as correct version of cocoapods are introduced in #8248 ## Test plan
piaskowyk
reviewed
Oct 16, 2025
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Outdated
Show resolved
Hide resolved
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Outdated
Show resolved
Hide resolved
piaskowyk
reviewed
Oct 16, 2025
packages/react-native-worklets/apple/worklets/apple/AnimationFrameQueue.mm
Outdated
Show resolved
Hide resolved
patrycjakalinska
deleted the
@patrycjakalinska/macos-example-bump-0.79
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
## Summary Currently, animating props synchronously is broken on React Native 0.80 or older because `schedulerDidSynchronouslyUpdateViewOnUIThread:props:` method that we're using was added facebook/react-native#51470 in which was released in React Native 0.81. In #8248, @patrycjakalinska added ifdefs to disable this flow on `react-native-macos` but it is not a problem with macOS itself but rather with the version of React Native (currently, `macos-example` runs on 0.79). This PR fixes animating props synchronously on iOS on React Native 0.80 and older. ## Test plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings back to life macos-example. It's working on the latest
react-native-macosstable version -0.79. The version is patched because of usage of depracated function that broke animations. I've already opened a PR inreact-native-macosrepo, and when (and if) it will be resolved we should update deps accordingly.Screen.Recording.2025-09-30.at.08.33.35.mov
Test plan
Run macos-example and check some examples.