[General] Pass testID to native side in dev
#3883
Open
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
approved these changes
Dec 18, 2025
Contributor
m-bert
left a comment
m-bert
left a comment
There was a problem hiding this comment.
I like this idea. Also, I've noticed that createNativeWrapper does not pass testID to child, as it did before (probably I forgot to include it). Could you add it here? Or do we want to have that separated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the past, there were cases where I needed to debug how multiple gestures influenced each other. Identifying which gesture is which was a bit challenging when there were multiple of the same type.
I figured, since we already have a
testIDproperty on each gesture, we may as well propagate that to the native side. This should make debugging multi-gesture configs much easier.This is only set in development builds; the only cost in production is one more pointer in the gesture object.
Test plan
Verify that the test ID is set correctly on the native side.