State Manager

[akwasniewski]

Description

Implements V3 State Manager, to manually manage gestures.

Test plan

Tested on the following example, the long press should activate instantely, while the minDuration is extremely big.

Details

import React from 'react';
import { View, Text, StyleSheet } from 'react-native';
import { GestureHandlerRootView, GestureDetector, useLongPressGesture, GestureStateManager } from 'react-native-gesture-handler';

export default function TwoPressables() {
  const longPress = useLongPressGesture({
    onTouchesDown: (e) => {
      'worklet';
      console.log("touches down")
      GestureStateManager.begin(e.handlerTag)
      GestureStateManager.activate(e.handlerTag)
    },
    onActivate: () => {
      'worklet';
      console.log("long pressed")

    },
    minDuration: 100000000,
    disableReanimated: true
  })
  return (
    <GestureHandlerRootView>
      <View style={styles.root}>
        <GestureDetector gesture={longPress}>
          <View style={styles.outer}>
            <Text style={styles.label}>Outer</Text>
          </View>
        </GestureDetector>
      </View>
    </GestureHandlerRootView>
  );
}

const styles = StyleSheet.create({
  root: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#f7f7f7',
  },
  outer: {
    padding: 20,
    backgroundColor: '#ddd',
    borderRadius: 12,
  },
  label: {
    fontSize: 18,
    marginBottom: 10,
  },
});

[m-bert]

Shouldn't this be added as global.d.ts?

[j-piasecki]

Wouldn't that leak those definitions outside of the library?

[m-bert]

Actually you might be right. As far as I remember we did it with @tjzel to overcome some TS problems, but this may be a better solution.

[j-piasecki]

Can we maybe get rid of the file you linked with this approach?

[m-bert]

It doesn't exist on next 😅

[tjzel]

We made the global.d.ts file with @m-bert so it's read only when developing the package and it's not exposed to the library consumer. If you leave this declare cost here then it will leak to the user.

You should move these types to global.d.ts.

[akwasniewski]

Thanks, done in 30c8c82

[j-piasecki]

LGTM, but please wait for the comments to be resolved.

[m-bert]

I'm not sure if I'm a fan of .begin(tag), something along .for(tag).begin() in my opinion fits better, but given that it is relatively new feature maybe simpler API will be better.

[m-bert]

#3880 (comment) 😅

[j-piasecki]

Hmm, StateManager.forTag(tag).begin() sounds nice, but we'd need to create a new state manager for each forTag(tag) invocation. Though it's possible that the impact of that is negligible.

Edit: Maybe let's stick to the current approach, and we will see what feedback we get on that. WDYT?

[akwasniewski]

Hmm, StateManager.forTag(tag).begin() sounds nice, but we'd need to create a new state manager for each forTag(tag) invocation. Though it's possible that the impact of that is negligible.

Edit: Maybe let's stick to the current approach, and we will see what feedback we get on that. WDYT?

To be honest I prefer the simpler approach, but if you both want it to be forTag(tag).begin() then by the virtues of democracy I will change it. Let's see what feedback we get, and then decide.

[m-bert]

I know it might be an overkill, but since we have two different implementations, maybe we could introduce an interface to make sure that they both meet the same criteria? This probably won't change, but it won't hurt us to have one. Let me know what you think.

[m-bert]

Suggested change

	begin(handlerTag: number): void {
	begin(handlerTag: number) {

I don't think we need those type declarations here.

[akwasniewski]

a020b99

[akwasniewski]

I know it might be an overkill, but since we have two different implementations, maybe we could introduce an interface to make sure that they both meet the same criteria? This probably won't change, but it won't hurt us to have one. Let me know what you think.

They are different by design, one is gesture specific, and the other global, accepting handlerTag

EDIT: as we discussed in the office, I misunderstood. Good idea, added interface in 7fa4cfa

[m-bert]

Merry Christmas 🎄🎅