-
-
Notifications
You must be signed in to change notification settings - Fork 1k
[Web] Fix handling of enabled prop
#3726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akwasniewski
reviewed
Oct 1, 2025
packages/react-native-gesture-handler/src/web/handlers/GestureHandler.ts
Show resolved
Hide resolved
j-piasecki
reviewed
Oct 2, 2025
packages/react-native-gesture-handler/src/web/tools/GestureHandlerWebDelegate.ts
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/web/tools/EventManager.ts
Outdated
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/web/handlers/GestureHandler.ts
Show resolved
Hide resolved
packages/react-native-gesture-handler/src/web/handlers/GestureHandler.ts
Show resolved
Hide resolved
j-piasecki
approved these changes
Oct 22, 2025
Contributor
Author
|
I've changed it a bit and removed reset of |
j-piasecki
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, if one changes
enabledproperty of handlers tofalse, they can never activate again. In the following example:gesture will never become active, even if
enabledchanges totrue. Same happens whenenabledis set totrueand then changed tofalseandtrueagain.This happens because we set
enabledtotrueby default insetGestureConfig, thus the following check:passes only when
config.enabledisfalse.I've set
enabledtonullby default, and then ifconfig.enabledis defined, it is assigned given value. Else default will betrue. To fix the issue, I've removed reset ofenabledinresetConfigmethod.Alternative approach would be to follow Android implementation and always react to changes in$\rightarrow$ $\rightarrow$
enabledeven in cases likefalsefalseandtruetrue.Test plan
Tested on the following code: