fix: turn off build IDs for reproducibility #3602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://gitlab.com/IzzyOnDroid/repo/-/wikis/Reproducible-Builds/RB-Hints-for-Developers#no-funny-build-time-generated-ids for context. I've successfully used these changes for a little while on my own app.
m-bert
requested changes
Jul 7, 2025
m-bert
approved these changes
Jul 8, 2025
j-piasecki
pushed a commit
that referenced
this pull request
Jul 22, 2025
## Description see https://gitlab.com/IzzyOnDroid/repo/-/wikis/Reproducible-Builds/RB-Hints-for-Developers#no-funny-build-time-generated-ids for context. ## Test plan I've successfully used these changes for a little while on my own app.
Rexogamer
added a commit
to Rexogamer/react-native-reanimated
that referenced
this pull request
Aug 1, 2025
tomekzaw
reviewed
Aug 6, 2025
Comment on lines
+168
to
+170
| ndkBuild { | ||
| arguments "APP_LDFLAGS+=-Wl,--build-id=none" | ||
| } |
There was a problem hiding this comment.
RNGH doesn't use ndk (only cmake) so it seems like those lines are irrelevant?
There was a problem hiding this comment.
Yes, I'll get back to it later 😅 Thanks for pointing this out ❤️
m-bert
added a commit
that referenced
this pull request
Aug 6, 2025
j-piasecki
pushed a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see https://gitlab.com/IzzyOnDroid/repo/-/wikis/Reproducible-Builds/RB-Hints-for-Developers#no-funny-build-time-generated-ids for context.
Test plan
I've successfully used these changes for a little while on my own app.