fix(util): support brace expansion globs containing commas in parseInputFiles

[Copilot]

Problem

The parseInputFiles function was using a naive split(',') to parse comma-delimited file patterns, which broke valid glob patterns containing commas inside brace groups.

For example, a common glob pattern like:

files: |
  ./**/*.{exe,deb,tar.gz}

Would incorrectly be split into three separate invalid patterns:

['./**/*.{exe', 'deb', 'tar.gz}']

This caused the glob matching to fail since the patterns were malformed.

Solution

Implemented a smartSplit() helper function that:

• Tracks brace depth while iterating through each character
• Only splits on commas when outside of braces (braceDepth === 0)
• Preserves commas inside brace groups as part of the pattern
• Trims whitespace from each result

Updated parseInputFiles() to:

• Split lines by newlines (unchanged behavior)
• Use smartSplit() instead of naive String.split(',')
• Use flatMap() for cleaner code structure

Examples

Now Works Correctly

parseInputFiles('./**/*.{exe,deb,tar.gz}')
// → ['./**/*.{exe,deb,tar.gz}']  ✅

parseInputFiles('./**/*.{exe,deb,tar.gz}\nfoo,bar')
// → ['./**/*.{exe,deb,tar.gz}', 'foo', 'bar']  ✅

Backward Compatibility Maintained

parseInputFiles('foo,bar')
// → ['foo', 'bar']  ✅

parseInputFiles('foo\nbar\nbaz')
// → ['foo', 'bar', 'baz']  ✅

parseInputFiles('foo,bar\nbaz,boom')
// → ['foo', 'bar', 'baz', 'boom']  ✅

Testing

Added comprehensive test coverage including:

• Glob patterns with brace groups containing commas
• Multiple brace groups on the same line
• Nested braces (e.g., path/{a,{b,c}}/file.txt)
• Mixed newlines and commas with braces
• Empty comma-separated values
• Whitespace handling

All 44 tests pass (7 new tests added), including all existing tests to ensure backward compatibility.

Fixes #659

Original prompt

---

This section details on the original issue you should resolve

<issue_title>files not support glob match files: '.**/*.{exe,deb,tar.gz}'</issue_title>
<issue_description>I find , will split ,but glob allow '.**/*.{exe,deb,tar.gz}' match

action-gh-release/src/util.ts

Line 48 in 19cd0bc

.concat(line.split(','))

</issue_description>

<agent_instructions>Fix the bug described in issue #659 – “files not support glob match files: './*.{exe,deb,tar.gz}'”**.

Problem

Currently, parseInputFiles in src/util.ts splits on commas (line.split(',')), which breaks valid glob patterns containing commas inside {} groups like:

files: |
./**/*.{exe,deb,tar.gz}

This causes the string to be split into invalid patterns ('.**/*.{exe', 'deb', 'tar.gz}').

Required Fix

Modify parseInputFiles so that it:

Still supports newline-delimited and comma-delimited lists for separate patterns.

Ignores commas inside {} groups when splitting (so .**/*.{exe,deb,tar.gz} remains one pattern).

Example expected behavior:

parseInputFiles('./*.{exe,deb,tar.gz}\nfoo,bar')
// → ['./*.{exe,deb,tar.gz}', 'foo', 'bar']

Implementation hint

A simple way:

Use a small parser that tracks brace depth while splitting on commas.

Only split when comma appears outside braces.

Example algorithm (you can refine it):

function smartSplit(input: string): string[] {
const result: string[] = [];
let current = '';
let braceDepth = 0;
for (const ch of input) {
if (ch === '{') braceDepth++;
if (ch === '}') braceDepth--;
if (ch === ',' && braceDepth === 0) {
result.push(current.trim());
current = '';
} else {
current += ch;
}
}
if (current.trim()) result.push(current.trim());
return result;
}

Then in parseInputFiles:

export const parseInputFiles = (files: string): string[] => {
return files
.split(/\r?\n/)
.flatMap((line) => smartSplit(line))
.filter((pat) => pat.trim() !== '');
};

Tests

Add unit tests in tests/util.test.ts:

it('handles globs with brace groups containing commas', () => {
assert.deepStrictEqual(
parseInputFiles('./*.{exe,deb,tar.gz}\nfoo,bar'),
['./*.{exe,deb,tar.gz}', 'foo', 'bar']
);
});

it('handles single-line brace pattern correctly', () => {
assert.deepStrictEqual(parseInputFiles('./*.{exe,deb,tar.gz}'), [
'./*.{exe,deb,tar.gz}',
]);
});

Validation

After implementation:

Run npm test to ensure new and existing tests pass.

Commit with:

fix(util): support brace expansion globs containing commas in parseInputFiles
test(util): add coverage for brace expansion glob parsing</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #659

---

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.