Skip to content

The action should fail with an error if the files: settings are not valid #383

@rpdelaney

Description

@rpdelaney

Example: https://github.com/rpdelaney/downforeveryone/actions/runs/6149726050/job/16686210047

🤔 dist/downforeveryone*.whl,dist/downforeveryone*.tar.gz not include valid file.

Instead of simply failing, this workflow run instead published a release with all the files in the repo: https://github.com/rpdelaney/downforeveryone/releases/tag/v1.0.5

This is a significant issue because it hides the fact that the action is not doing what the user expected and ends with success. The warnings are buried in the folds so I did not discover the problem until the release archive was already out there and downloaded.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions