Skip to content

Conversation

@kangaroooh
Copy link

sketching a possible "fix" for facebook#14039 for discussion.

  • icky error message, I know.
  • can't think of a good test for this, open to suggestions. should I mock the dispatcher to trigger this specific error? sounds self serving.
  • should probably add a TODO to remove this in v17

@softagram-bot
Copy link

Softagram Impact Report for pull/11 (head commit: 343a70d)

⭐ Visual Overview

Changed elements and changed dependencies.
Changed dependencies - click for full size
Graph legend
(Open in Softagram Desktop for full details)

⭐ Change Impact

How the changed files are used by the rest of the project
Impacted files - click for full size
Graph legend
(Open in Softagram Desktop for full details)

💡 Insights

  • Co-change Alert: You modified ReactHooks.js. Often ReactFiberHooks.js (react-reconciler/src) is modified at the same time.

📄 Full report

Give feedback of this report to [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants