Switch to maven central #1092
Switch to maven central #1092
Conversation
WalkthroughThis change adds a Changes
Sequence Diagram(s)No sequence diagram generated, as the changes are limited to build metadata and configuration. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1092 +/- ##
============================================
+ Coverage 77.77% 77.92% +0.14%
- Complexity 911 912 +1
============================================
Files 175 175
Lines 7383 7383
Branches 1082 1082
============================================
+ Hits 5742 5753 +11
+ Misses 1092 1081 -11
Partials 549 549 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (4)
sofa-ark-parent/pom.xml (1)
14-15: Same note on descriptive<name>elementsofa-ark-parent/core/api/pom.xml (1)
13-14: Same note on descriptive<name>elementsofa-ark-parent/core-impl/archive/pom.xml (1)
11-12: Same note on descriptive<name>elementsofa-ark-parent/assembly/pom.xml (1)
11-12: Same note on descriptive<name>element
🧹 Nitpick comments (7)
sofa-ark-parent/support/pom.xml (1)
13-13: Consider a human-readable<name>valueMaven Central’s UI and generated docs show the
<name>verbatim. While the coordinate${project.groupId}:${project.artifactId}is valid, a descriptive label such as “SOFA-Ark Support Parent” is easier for humans to scan. Optional, but improves UX across repository browsers.sofa-ark-parent/core/exception/pom.xml (1)
11-12: Prefer a human-readable<name>over coordinatesSonatype’s Maven Central guidelines encourage a descriptive project name (e.g. “SOFA Ark Exception”) rather than repeating the coordinates. This is purely cosmetic and will not block deployment, but a friendlier name makes the generated POM easier to scan.
sofa-ark-parent/core/spi/pom.xml (1)
11-11:<name>value is machine-readable rather than human-friendly
${project.groupId}:${project.artifactId}is perfectly valid metadata, but Maven’s<name>is usually intended for a human-facing description (it shows up in generated sites, Bill-of-Materials, etc.). Using purely coordinates can reduce readability for consumers browsing the artifacts.No action required, just flagging in case the team prefers descriptive names like “SOFA-Ark SPI”.
sofa-ark-plugin/config-ark-plugin/pom.xml (1)
14-14: Same note on human-readable module nameConsider whether a descriptive label such as “SOFA-Ark Config Plugin” would better serve downstream users than raw coordinates.
sofa-ark-parent/core/common/pom.xml (1)
11-11: Descriptive<name>might aid artifact discoveryWhile coordinates are technically fine, a friendlier string (e.g., “SOFA-Ark Common Utilities”) is often more helpful in generated docs.
sofa-ark-plugin/pom.xml (1)
15-15: Aggregating POM could expose clearer project titleThis parent POM is an aggregator; you may want the
<name>to reflect that role (“SOFA-Ark Plugins (Aggregator)”) for clarity in repository browsers.sofa-ark-parent/support/ark-tools/pom.xml (1)
11-11: Optional: replace coordinates with descriptive tool nameE.g., “SOFA-Ark Development Tools”. Improves readability in Maven Central listings.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (25)
pom.xml(7 hunks)sofa-ark-bom/pom.xml(1 hunks)sofa-ark-parent/assembly/pom.xml(1 hunks)sofa-ark-parent/core-impl/archive/pom.xml(1 hunks)sofa-ark-parent/core-impl/container/pom.xml(1 hunks)sofa-ark-parent/core-impl/pom.xml(1 hunks)sofa-ark-parent/core/api/pom.xml(1 hunks)sofa-ark-parent/core/common/pom.xml(1 hunks)sofa-ark-parent/core/exception/pom.xml(1 hunks)sofa-ark-parent/core/pom.xml(1 hunks)sofa-ark-parent/core/spi/pom.xml(1 hunks)sofa-ark-parent/pom.xml(1 hunks)sofa-ark-parent/support/ark-maven-plugin/pom.xml(1 hunks)sofa-ark-parent/support/ark-plugin-maven-plugin/pom.xml(1 hunks)sofa-ark-parent/support/ark-springboot-integration/ark-common-springboot/pom.xml(1 hunks)sofa-ark-parent/support/ark-springboot-integration/ark-compatible-springboot1/pom.xml(1 hunks)sofa-ark-parent/support/ark-springboot-integration/ark-compatible-springboot2/pom.xml(1 hunks)sofa-ark-parent/support/ark-springboot-integration/ark-springboot-starter/pom.xml(1 hunks)sofa-ark-parent/support/ark-support-starter/pom.xml(1 hunks)sofa-ark-parent/support/ark-tools/pom.xml(1 hunks)sofa-ark-parent/support/pom.xml(1 hunks)sofa-ark-plugin/config-ark-plugin/pom.xml(1 hunks)sofa-ark-plugin/netty-ark-plugin/pom.xml(1 hunks)sofa-ark-plugin/pom.xml(1 hunks)sofa-ark-plugin/web-ark-plugin/pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: build
- GitHub Check: build
- GitHub Check: sca
🔇 Additional comments (15)
sofa-ark-parent/support/ark-springboot-integration/ark-compatible-springboot2/pom.xml (1)
14-14: Consistent<name>metadata – looks goodThe addition aligns with Maven Central requirements and the pattern used across all modules. No issues spotted.
sofa-ark-parent/core/pom.xml (1)
11-11:<name>tag addition validatedStandard‐conforming and helpful for repository browsing; nothing further to address here.
sofa-ark-parent/core-impl/container/pom.xml (1)
11-11: Metadata improvement acceptedThe new
<name>element is correct and keeps the module in sync with the rest of the build.sofa-ark-parent/support/ark-support-starter/pom.xml (1)
13-13: Good addition of<name>elementNo functional impact; enhances artifact readability in Central.
sofa-ark-parent/support/ark-plugin-maven-plugin/pom.xml (1)
13-13:<name>field correctly introducedChange is straightforward and consistent with other modules.
sofa-ark-parent/core-impl/pom.xml (1)
11-11: Metadata<name>element addition is appropriateThe new
<name>${project.groupId}:${project.artifactId}</name>satisfies Maven Central’s requirement for an explicit project name and follows the same convention applied across the repo. No further action needed.sofa-ark-plugin/netty-ark-plugin/pom.xml (1)
15-15: Consistent naming convention appliedAdding the
<name>field keeps this module aligned with the rest of the multi-module build and improves readability on Maven Central. Looks good.sofa-ark-parent/support/ark-maven-plugin/pom.xml (1)
14-14: POM metadata enhancedIncluding a
<name>element here is a welcome improvement for artifact discoverability. No issues spotted.sofa-ark-plugin/web-ark-plugin/pom.xml (1)
14-14: LGTM –<name>tag addedThe update follows the new project-wide standard and has no impact on build behavior.
sofa-ark-parent/support/ark-springboot-integration/ark-compatible-springboot1/pom.xml (1)
14-14: Project name field added correctlyThe change brings this Spring-Boot 1 compatibility module in line with the rest of the POMs. All good.
sofa-ark-parent/support/ark-springboot-integration/ark-common-springboot/pom.xml (1)
14-14: Consistent artifact naming metadata added – looks goodAdding
<name>${project.groupId}:${project.artifactId}</name>keeps module metadata uniform across the multi-module build and improves discoverability on Maven Central.sofa-ark-bom/pom.xml (1)
14-14: BOM now exposes a clear<name>– approvedThe extra
<name>in the BOM POM is harmless and aligns with the new convention adopted project-wide.sofa-ark-parent/support/ark-springboot-integration/ark-springboot-starter/pom.xml (1)
18-18: Starter module metadata aligned – no issuesThe new
<name>element follows the same pattern as other modules; this is beneficial for Central search.pom.xml (2)
17-17: Snapshot → release property bump – verify downstream expectationsChanging
sofa.ark.versionto the released2.3.2is correct for a Central push, but double-check:
- All child modules inherit this property (they reference
${project.version}in many places).- CI/CD pipelines and any consumer projects are ready for the non-SNAPSHOT version.
230-336: New Sonatype endpoints may not be Maven-resolvable – please validateThe URLs were switched to:
https://ossrh-staging-api.central.sonatype.com/…https://central.sonatype.com/repository/maven-snapshots/These domains are not the usual repo hosts (
s01.oss.sonatype.orgoross.sonatype.org). If these endpoints are incorrect, releases and snapshots will fail to deploy/resolve.
Furthermore, the default profile (Lines 345-362) still points to the legacy snapshot repo, creating inconsistency.Action items:
- Confirm with Sonatype docs that the new endpoints are valid for REST staging and snapshot download.
- Align the
defaultprofile repositories with whichever endpoint you choose to prevent environment-dependent behaviour.
Summary by CodeRabbit