[BuiltConstraintSolver] Add SVD based regularization strategy #5722
+169
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…info in GenericCosntraintSolver data that are dependent on the method type. Need to find a way of setting the solving method by adding a component in the scene.
…ritance. Now the constraintProblem is only a container
… still being used
…_constraint_solver
bakpaul
added
pr: status to review
hugtalbot
changed the title
th-skam
reviewed
Oct 20, 2025
Contributor
th-skam
left a comment
th-skam
left a comment
There was a problem hiding this comment.
A few comments and suggestions for this very useful PR
.../Lagrangian/Solver/src/sofa/component/constraint/lagrangian/solver/BuiltConstraintSolver.cpp
Show resolved
Hide resolved
.../Lagrangian/Solver/src/sofa/component/constraint/lagrangian/solver/BuiltConstraintSolver.cpp
Outdated
Show resolved
Hide resolved
Contributor
|
[ci-build][with-all-tests] |
bakpaul
added
the
pr: status wip
fredroy
removed
the
pr: status to review
bakpaul
added
pr: status to review
Contributor
Author
|
[ci-build][with-all-tests] |
th-skam
approved these changes
Nov 17, 2025
fredroy
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5666
This PR adds a regularization strategy that uses SVD to explore the NullSpace of the matrix to only add regularization to constraints that have antagonists constraints.
meaningful commit: 30f81e4
Introduced example
The added example shows a beam attached at both sides and which center is constrained in two different positions, meaning that two antagonists constraints are imposed to the center. The idea is that, because the fixations are not faulty, then we want them to be fully solved and we don't want to perturb them while still releasing the constraints on the antagonists ones.
With SVD
Without SVD
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if