Skip to content

[Lagrangian] Add corrected Jacobi constraint solving method #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

[Lagrangian] Add corrected Jacobi constraint solving method #5680

wants to merge 18 commits into from

Conversation

@bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Aug 29, 2025 •
edited
Loading

Tried to add a new simple constraint solving method as a ConstraintSovler using introduced refactoring in #5666
It is basically a Jacobi with a bit of conjugate residue.

I plan to make is multithreaded to be able to run the added example at more than 3Hz...

⚠️ Of course, based on #5666

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

bakpaul added 4 commits August 25, 2025 17:38
@bakpaul
First working version of exploded constraint problrms. Still lots of …
98c593d 
…info in GenericCosntraintSolver data that are dependent on the method type. Need to find a way of setting the solving method by adding a component in the scene.
@bakpaul
Changed all problems into solvers. It makes more sense to use an inhe…
e2aa322 
…ritance. Now the constraintProblem is only a container
@bakpaul
Apply changes to scenes, tests and tutorials
fd67c12
@bakpaul
Add stopping ocndition based on constraint force evolutionr ate as pr…
200e4d8 
…oposed in the original paper
@bakpaul bakpaul added pr: status to review To notify reviewers to review this pull-request pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently labels Aug 29, 2025
@hugtalbot hugtalbot changed the title [Lagrangian] Add corrected jacobi constraint solving method [Lagrangian] Add corrected Jacobi constraint solving method Sep 3, 2025
@hugtalbot hugtalbot added pr: new feature Implement a new feature pr: highlighted in next release Highlight this contribution in the notes of the upcoming release labels Sep 10, 2025
@bakpaul bakpaul force-pushed the 25_08_add_corrected_jacobi_constraint_solving_method branch from ebffdd6 to 3e8b76a Compare October 20, 2025 15:49
@fredroy
Copy link
Contributor

fredroy commented Oct 23, 2025

[ci-build][with-all-tests]

@hugtalbot hugtalbot requested a review from alxbilger October 30, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alxbilger alxbilger Awaiting requested review from alxbilger

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently pr: highlighted in next release Highlight this contribution in the notes of the upcoming release pr: new feature Implement a new feature pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bakpaul @fredroy @alxbilger @hugtalbot