-
Notifications
You must be signed in to change notification settings - Fork 12
Feature/duck db #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature/duck db #206
Conversation
Hi @ilias1111, I'm getting a failed test:
I'm not sure if it's just my setup. Is it passing on your end ? |
@spinx It should be passing, given the tests passed in the CI, in which platform are you getting the error, in Duck? |
Yes, in DuckDB. I'll consider this done from my end then! Thanks for confirming. |
Hi @spinx , I had a look as well and it failed for me locally as well on the same test. It seems we are dealing with a similar issue we faced on spark where the timezone handling was not accurate when using the standard date_add function so I had to resort to using a similar, epoch based resolution to work around this. The tests pass for me now locally, the automated pr_tests fail for an unrelated reason we are aware of and will be fixed shortly. Let me know if this fixes it on your end (or if you find a better workaround). |
d46c9a0
to
41900f7
Compare
Description
Add support for DuckDB
What type of PR is this? (check all applicable)
Related Tickets & Documents
Checklist
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?