Skip to content

Conversation

ilias1111
Copy link
Contributor

@ilias1111 ilias1111 commented Jun 17, 2025

Description

Add support for DuckDB

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Checklist

  • πŸ’£ Is your change a breaking change?
  • πŸ“– I have updated the CHANGELOG.md

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ““ internal package docs (ymls, macros, readme, if applicable)
  • πŸ“• I have raised a Snowplow documentation PR if applicable (Link here if required)
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@ilias1111 ilias1111 requested a review from a team as a code owner June 17, 2025 07:39
@ilias1111 ilias1111 mentioned this pull request Jun 18, 2025
9 tasks
@spinx
Copy link

spinx commented Jul 1, 2025

Hi @ilias1111,

I'm getting a failed test:

Failure in test dbt_utils_expression_is_true_test_get_run_limits_expected_upper_limit_actual_upper_limit (models/incremental_hooks/incremental_hooks.yml)

I'm not sure if it's just my setup. Is it passing on your end ?

@ilias1111
Copy link
Contributor Author

ilias1111 commented Jul 2, 2025

Hi @ilias1111,

I'm getting a failed test:

Failure in test dbt_utils_expression_is_true_test_get_run_limits_expected_upper_limit_actual_upper_limit (models/incremental_hooks/incremental_hooks.yml)

I'm not sure if it's just my setup. Is it passing on your end ?

@spinx It should be passing, given the tests passed in the CI, in which platform are you getting the error, in Duck?

@spinx
Copy link

spinx commented Jul 2, 2025

Hi @ilias1111,
I'm getting a failed test:

Failure in test dbt_utils_expression_is_true_test_get_run_limits_expected_upper_limit_actual_upper_limit (models/incremental_hooks/incremental_hooks.yml)

I'm not sure if it's just my setup. Is it passing on your end ?

@spinx It should be passing, given the tests passed in the CI, in which platform are you getting the error, in Duck?

Yes, in DuckDB. I'll consider this done from my end then! Thanks for confirming.

@agnessnowplow
Copy link
Contributor

Hi @spinx , I had a look as well and it failed for me locally as well on the same test. It seems we are dealing with a similar issue we faced on spark where the timezone handling was not accurate when using the standard date_add function so I had to resort to using a similar, epoch based resolution to work around this. The tests pass for me now locally, the automated pr_tests fail for an unrelated reason we are aware of and will be fixed shortly. Let me know if this fixes it on your end (or if you find a better workaround).

@spinx spinx mentioned this pull request Jul 9, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants