Skip to content

SNOW-1955965: Fix expired S3 credentials update #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2025
Merged

SNOW-1955965: Fix expired S3 credentials update #2258

merged 5 commits into from
Apr 10, 2025

Conversation

sfc-gh-pbulawa
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1955965

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Fix expired S3 credentials update and increment retry when expired credentials are found.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-pbulawa sfc-gh-pbulawa added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Apr 9, 2025
sfc-gh-mkubik
sfc-gh-mkubik approved these changes Apr 9, 2025
View reviewed changes
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit ed7ad49 into main Apr 10, 2025
95 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-1955965-put-fix branch April 10, 2025 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-knozderko sfc-gh-knozderko sfc-gh-knozderko approved these changes

+1 more reviewer

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-pbulawa @sfc-gh-knozderko @sfc-gh-mkubik