Skip to content

SNOW-2027116 Allow for UUID encoding in SnowflakeRestful interface #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

SNOW-2027116 Allow for UUID encoding in SnowflakeRestful interface #2254

merged 2 commits into from
Apr 9, 2025

Conversation

sfc-gh-lspiegelberg
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2027116

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    On the old driver CI, the restful interface failed when UUID objects are passed. Fix by using in network.py::SnowflakeRestful a customized JSON encoder (subclassed from Python) which adds support for Python UUID objects.

  4. (Optional) PR for stored-proc connector:
    not applicable.

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg added bug NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Apr 4, 2025
@sfc-gh-lspiegelberg
Copy link
Contributor Author

CI context: https://github.com/snowflakedb/snowflake-connector-python/actions/runs/14270646724/job/40002935251

@sfc-gh-lspiegelberg sfc-gh-lspiegelberg marked this pull request as ready for review April 4, 2025 19:33
sfc-gh-heshah
sfc-gh-heshah approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-heshah sfc-gh-heshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sfc-gh-mmishchenko
Copy link
Collaborator

Could you, please, address the faling [Build and Test / Old Driver Test linux-3.9-aws (pull_request)] check?

@sfc-gh-mmishchenko sfc-gh-mmishchenko force-pushed the ls-SNOW-2027116-json-serialize-for-old-driver branch from 7b7906b to 5b410a7 Compare April 8, 2025 14:31
@sfc-gh-mmishchenko sfc-gh-mmishchenko merged commit 017848e into main Apr 9, 2025
94 of 95 checks passed
@sfc-gh-mmishchenko sfc-gh-mmishchenko deleted the ls-SNOW-2027116-json-serialize-for-old-driver branch April 9, 2025 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-heshah sfc-gh-heshah sfc-gh-heshah approved these changes

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

@sfc-gh-bdrutu sfc-gh-bdrutu Awaiting requested review from sfc-gh-bdrutu

Assignees
No one assigned
Labels
bug DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-lspiegelberg @sfc-gh-mmishchenko @sfc-gh-heshah