Fix branch filtering for complex tests #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akode
pushed a commit
to akode/snorkel
that referenced
this pull request
Jun 10, 2022
## Description of proposed changes This fixes the CI for the Complex Tests, during the migration to Circle there was an error in the branch filtering for when to run the complex tests resulting in them not being run upon a merge. This has been fixed ## Related issue(s) Fixes # (issue) ## Test plan I tested this in a forked version of the repo and confirmed that when I set the branch names in the new way the complex tests will be run and they won't otherwise ## Checklist Need help on these? Just ask! * [ ] I have read the **CONTRIBUTING** document. * [ ] I have updated the documentation accordingly. * [ ] I have added tests to cover my changes. * [ ] I have run `tox -e complex` and/or `tox -e spark` if appropriate. * [ ] All new and existing tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This fixes the CI for the Complex Tests, during the migration to Circle there was an error in the branch filtering for when to run the complex tests resulting in them not being run upon a merge. This has been fixed
Related issue(s)
Fixes # (issue)
Test plan
I tested this in a forked version of the repo and confirmed that when I set the branch names in the new way the complex tests will be run and they won't otherwise
Checklist
Need help on these? Just ask!
tox -e complexand/ortox -e sparkif appropriate.