Fix squeeze bug for length 1 array, and inconsistency on requirements and setup.py #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| include_package_data=True, | ||
| install_requires=[ | ||
| "munkres==1.1.2", | ||
| "munkres>=1.0.6", |
There was a problem hiding this comment.
are these version commits related to this patch?
There was a problem hiding this comment.
They're not, but tox -e check was failing without it.
There was a problem hiding this comment.
I'll try reverting it and see if travis ci passes.
There was a problem hiding this comment.
CI fails if I revert.
Comment on lines
+24
to
+27
| Y = to_int_label_array(np.array([[1]]), flatten_vector=True) | ||
| Y_expected = np.array([1]) | ||
| np.testing.assert_array_equal(Y, Y_expected) | ||
|
|
brahmaneya
force-pushed
the
squeezefix
branch
from
06964e2 to
3424671
Compare
Codecov Report
@@ Coverage Diff @@
## master #1540 +/- ##
==========================================
+ Coverage 97.11% 97.11% +<.01%
==========================================
Files 55 55
Lines 2077 2079 +2
Branches 341 342 +1
==========================================
+ Hits 2017 2019 +2
Misses 31 31
Partials 29 29
|
brahmaneya
force-pushed
the
squeezefix
branch
from
3424671 to
eb1a2e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Description of proposed changes
Squeezing a length 1 array for used to create a scalar instead of a 1D array as intended. Fixed by adding an extra check.
Also made munkres version in setup.py consistent with requirements.
Test plan
Update unit test for changed function.
Checklist
Need help on these? Just ask!
tox -e complexand/ortox -e sparkif appropriate.