Add fault tolerance to appliers #1480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## fault #1480 +/- ##
==========================================
+ Coverage 97.63% 97.65% +0.02%
==========================================
Files 56 56
Lines 2070 2093 +23
Branches 333 336 +3
==========================================
+ Hits 2021 2044 +23
Misses 22 22
Partials 27 27
|
henryre
added a commit
that referenced
this pull request
Oct 9, 2019
* Remove fault tolerant mode from LF/SF * Add fault tolerance to appliers (#1480)
henryre
added a commit
that referenced
this pull request
Oct 11, 2019
* Remove fault tolerant mode from LF/SF * Add fault tolerance to appliers (#1480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds fault tolerance to appliers. Allows LFs/SFs to fail (abstaining if they do) and records the number of failures for each LF/SF.
Note: we don't track failure metadata for Dask or PySpark in this PR, since merging across processes can be tricky. We can add later if requested.
Test plan
Added new unit tests for core, Pandas, Dask, and PySpark appliers. Ran
tox -e sparkandtox -e complex