Skip to content

Conversation

paroma
Copy link
Contributor

@paroma paroma commented Aug 23, 2019

Description of proposed changes

Raise a ValueError if the number of labeling functions input to the LabelModel is less than 3

Related issue(s)

#1427

Fixes #1426 and #1427

Test plan

Add test to check ValueError raised

Checklist

Need help on these? Just ask!

  • I have read the CONTRIBUTING document.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #1428 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   97.54%   97.54%   +<.01%     
==========================================
  Files          55       55              
  Lines        1994     1996       +2     
  Branches      326      327       +1     
==========================================
+ Hits         1945     1947       +2     
  Misses         22       22              
  Partials       27       27
Impacted Files Coverage Δ
snorkel/labeling/model/label_model.py 95.18% <100%> (+0.03%) ⬆️

@paroma paroma requested a review from henryre August 24, 2019 23:05
Copy link
Member

@henryre henryre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paroma paroma merged commit 414fc1d into master Aug 25, 2019
@paroma paroma deleted the lm-checks branch August 25, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug? single labeling function ignored
2 participants