Skip to content

test_augmented_L_construction failure after updating for networkx 2.5 #1644

@thatch

Description

@thatch

Issue description

Seeing as networkx 2.3 is more than a year old, I attempted to perform the trivial node/nodes change to make it work with networkx 2.5.

This uncovered a test failure in test_augmented_L_construction that I do not know enough about what it's doing to be able to fix.

Code example/repro steps

  1. Check out snorkel from git
  2. Apply https://gist.github.com/thatch/aee1a7332f7dbde003410027c0d44f57
  3. pip install -e .; pip install pytest
  4. python -m unittest test.labeling.model.test_label_model
  5. Observe failure in test_augmented_L_construction -- here is the L_aug
[[1. 0. 1. 0. 1. 0. 0. 1. 1. 0.]
 [1. 0. 0. 1. 0. 1. 1. 0. 0. 0.]
 [1. 0. 1. 0. 1. 0. 1. 0. 0. 0.]]

On success, the first j is 4, and the next is 2.

On failure, the first j is 6.

Expected behavior

The test would pass.

System info

  • How you installed Snorkel (conda, pip, source): git checkout, fresh virtualenv
  • Build command you used (if compiling from source): pip install -e .
  • OS: Linux
  • Python version: 3.8.6
  • Snorkel version: b3b0669 (plus a patch listed above)
  • Versions of any other relevant libraries:

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions