-
Notifications
You must be signed in to change notification settings - Fork 5
List plugin interface repos in README #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughExpands README.md from a brief description to a structured list detailing interfaces for six plugin types, each linking to its respective repository. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
3-3
: Tighten repo description to reflect interfacesSuggest clarifying that this repo provides shared interface/base definitions rather than generic “functions and classes.”
Apply:
-Common functions and classes for Snakemake and its plugins. +Common interface definitions and base classes used by Snakemake and its plugins.
6-13
: Good addition. Consider brief per-type descriptors and a lead-in sentenceThis looks useful. A short lead-in and concise descriptors per item will help newcomers pick the right interface quickly.
Proposed tweak:
## Interfaces for specific plugin types + - - Storage: [snakemake-interface-storage-plugins](https://github.com/snakemake/snakemake-interface-storage-plugins) - - Logger: [snakemake-interface-logger-plugins](https://github.com/snakemake/snakemake-interface-logger-plugins) - - Executor: [snakemake-interface-executor-plugins](https://github.com/snakemake/snakemake-interface-executor-plugins) - - Scheduler: [snakemake-interface-scheduler-plugins](https://github.com/snakemake/snakemake-interface-scheduler-plugins) - - Report: [snakemake-interface-report-plugins](https://github.com/snakemake/snakemake-interface-report-plugins) - - Software deployment: [snakemake-interface-software-deployment-plugins](https://github.com/snakemake/snakemake-interface-software-deployment-plugins) +The following repositories define the plugin interfaces for each subsystem: + +- Storage: [snakemake-interface-storage-plugins](https://github.com/snakemake/snakemake-interface-storage-plugins) — remote/object store and filesystem backends +- Logger: [snakemake-interface-logger-plugins](https://github.com/snakemake/snakemake-interface-logger-plugins) — structured logging sinks/handlers +- Executor: [snakemake-interface-executor-plugins](https://github.com/snakemake/snakemake-interface-executor-plugins) — job submission and execution backends +- Scheduler: [snakemake-interface-scheduler-plugins](https://github.com/snakemake/snakemake-interface-scheduler-plugins) — scheduling strategies and policies +- Report: [snakemake-interface-report-plugins](https://github.com/snakemake/snakemake-interface-report-plugins) — report generation and rendering +- Software deployment: [snakemake-interface-software-deployment-plugins](https://github.com/snakemake/snakemake-interface-software-deployment-plugins) — environment/software provisioningAlso please click through each link to verify they resolve to the intended repos and are up to date with current plugin taxonomy.
Summary by CodeRabbit