Track features for account based endpoints #4298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
…atures (corresponding metric value in parenthesis): ACCOUNT_ID_MODE_PREFERRED (P) ACCOUNT_ID_MODE_DISABLED (Q) ACCOUNT_ID_MODE_REQUIRED (R) RESOLVED_ACCOUNT_ID (T) Testing: - Integration tests for tracking account ID endpoint modes - Unit tests validate User-Agent metric emission
…atures (corresponding metric value in parenthesis): ACCOUNT_ID_MODE_PREFERRED (P) ACCOUNT_ID_MODE_DISABLED (Q) ACCOUNT_ID_MODE_REQUIRED (R) RESOLVED_ACCOUNT_ID (T) Testing: - Integration tests for tracking account ID endpoint modes - Unit tests validate User-Agent metric emission
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
approved these changes
Sep 18, 2025
aajtodd
approved these changes
Sep 18, 2025
aajtodd
reviewed
Sep 18, 2025
...n-aws-sdk/src/main/kotlin/software/amazon/smithy/rustsdk/AccountIdEndpointParamsDecorator.kt
Outdated
Show resolved
Hide resolved
aajtodd
reviewed
Sep 18, 2025
.../smithy/rust/codegen/client/smithy/endpoint/generators/EndpointParamsInterceptorGenerator.kt
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR tracks and emits metrics for the following AWS SDK features (corresponding metric value in parenthesis):
ACCOUNT_ID_MODE_PREFERRED(P)ACCOUNT_ID_MODE_DISABLED(Q)ACCOUNT_ID_MODE_REQUIRED(R)RESOLVED_ACCOUNT_ID(T)Testing
RESOLVED_ACCOUNT_IDBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.