Skip to content

Set enableStackTraceComments(true) on RustWriter #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Set enableStackTraceComments(true) on RustWriter #4290

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98b9d89
Set enableStackTraceComments(true) on RustWriter
landonxjames Sep 9, 2025
1f9b7f5
Merge branch 'main' into landonxjames/provenance
landonxjames Sep 9, 2025
601adbd
I blew up the stack :(
landonxjames Sep 9, 2025
a0a8651
Giving existing debugMode a shot
landonxjames Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/rustlang/RustWriter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ class RustWriter private constructor(
private val commentCharacter: String = "//",
private val printWarning: Boolean = true,
/** Insert comments indicating where code was generated */
val debugMode: Boolean = false,
val debugMode: Boolean = true,
/** When true, automatically change all dependencies to be in the test scope */
val devDependenciesOnly: Boolean = false,
) :
Expand Down Expand Up @@ -665,7 +665,7 @@ class RustWriter private constructor(
location.first { it.isRelevant() }?.let { "/* ${it.fileName}:${it.lineNumber} */" }
?.also { super.writeInline(it) }
}

// super.enableStackTraceComments(true)
return super.write(content, *args)
}

Expand Down Expand Up @@ -844,6 +844,7 @@ class RustWriter private constructor(
}
}
}

else ->
rustBlock("") {
block(variable)
Expand Down
Loading