Skip to content

fix issues in list and download #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2022
Merged

fix issues in list and download #9

merged 2 commits into from
Sep 8, 2022

Conversation

potatop
Copy link
Contributor

@potatop potatop commented Sep 7, 2022

Skip deserializing products vec on error, this can happen if there are none book bundles that has empty subproducts.
Replace invalid product name characters when downloading.

Copy link
Owner

@smbl64 smbl64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @potatop.
LGTM. Just had a comment about the dependency format.

@smbl64 smbl64 merged commit 57ce289 into smbl64:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants