feat: add and pass virtualKeyUrl param to onComplete handler
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 9 9
Branches 2 2
=========================================
Hits 9 9 ☔ View full report in Codecov by Sentry. |
angieashields
approved these changes
Dec 5, 2023
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For brands that require a virtual key to be registered on the vehicle in order to receive data and/or send commands to the vehicle, Smartcar will be sending back an additional query parameter,
virutal_key_url, when redirecting back with the authorizationcode. This PR:virtual_key_urlin the message that ispostMessage'd back to the originonCompleteto include a new parameter,virtualKeyUrlvirtualKeyUrlproperty on themessageobject to theonCompletefunction.From there, the
virtualKeyUrlcan be used within theonCompletethat is created by the developer, and passed onto the BE, etc. so that it can be sent to the appropriate vehicle owners.