Added dynamic priority support for jms similar to amqp #2915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozangunalp
requested changes
Feb 6, 2025
| if (type != null) { | ||
| outgoing.setJMSType(type); | ||
| } | ||
| if (priority != null) { |
There was a problem hiding this comment.
Shouldn't this set the priority on the outgoing message?
There was a problem hiding this comment.
That was my first thought too, but using outgoing.setJMSPriority(priority); is not working. Could this be a mapping problem with the jakarta.jms.Message outgoing?
Setting it directly on the sender did work for me (resourceHolder.getClient().setPriority(priority))
|
@User-123321123 Could you please have a look at the comments? |
|
@ozangunalp @User-123321123 what's the status on this one? |
|
I didn't have time to test this out. But setting the client priority for each outgoing message didn't seem feasible to me. In any case going forward, we'd need a test to back it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added priority to OutgoingJmsMessageMetadata, which allows setting the priority before sending the message. The ampq connector implementation provides a similar feature.