[6.4] fix memory leak in metrics #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that a random UUID is used as a value of the metrics tag `method` if the user doesn't set a description on `FaultTolerance`. These values are always held in memory, so in case more and more `FaultTolerance` objects without description are created, more and more memory is held. The fix is relatively simple: in case no description is set (and a random UUID should be used), no metrics are emitted. This is technically a breaking change, but it's better to require users to explicitly state the value of the metrics tag than to leak memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that a random UUID is used as a value of the metrics tag
methodif the user doesn't set a description onFaultTolerance. These values are always held in memory, so in case more and moreFaultToleranceobjects without description are created, more and more memory is held.The fix is relatively simple: in case no description is set (and a random UUID should be used), no metrics are emitted. This is technically a breaking change, but it's better to require users to explicitly state the value of the metrics tag than to leak memory.