feat: allow to customize markdown transformers #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Jul 20, 2024
| const replaced = code.replace('if (_rerender_only)', 'if (false)') | ||
| if (replaced !== code) | ||
| return replaced | ||
| return code.replace('if (_rerender_only)', 'if (false)') |
Member
There was a problem hiding this comment.
Why this get removed? In Vite plugin returning bullish value will bailout the transform process and will be more performant
Member
Author
There was a problem hiding this comment.
Because the module has been tested to be a slide module, it is almost impossible to not perform the replacement
antfu
approved these changes
Jul 20, 2024
antfu
approved these changes
Jul 20, 2024
This was referenced Jul 22, 2024
Open
This was referenced Aug 31, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1761. This PR will be much smaller after merging that.
close #1503,close #1626.
Usage docs