Skip to content

Add the new condition to the validation func for TextBlockObject #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2021
Merged

Add the new condition to the validation func for TextBlockObject #902

merged 1 commit into from
Mar 7, 2021

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Feb 26, 2021

What

  • Add the new validation condition that checks whether the value in the Type field is valid to the validation func for the TextBlockObject

Why

  • There may be a case that a user puts invalid value to this field such as mistaking it for other Struct or having a simple typo.

Ref

official API doc

@kanata2
Copy link
Member

kanata2 commented Mar 7, 2021

LGTM :)

@kanata2 kanata2 merged commit 87fa263 into slack-go:master Mar 7, 2021
@sryoya sryoya deleted the add_condition_to_the_validation_function_for_TextBlockObject branch March 9, 2021 09:26
This was referenced Mar 18, 2021
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanata2 kanata2 kanata2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sryoya @kanata2