Fix memory leak issues #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skydoves
approved these changes
May 19, 2022
Owner
skydoves
left a comment
skydoves
left a comment
There was a problem hiding this comment.
Looks good to me!
Thank you for your contribution :)
Contributor
Author
|
Great! Will you be releasing this to a new version? |
Owner
|
You can use this feature in the SNAPSHOT-1.2.2 build for now, I will release the next version as soon as possible. |
Contributor
Author
|
I seem to have some troubles using that snapshot (it's not resolving). But that can be on my side, since I haven't used snapshots in my Android projects before. Any thoughts on when you will release this? |
Owner
|
A new version |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #105 I have memory leak issues when using a PowerSpinnerView.
I think this issue is caused because of the observers that are being added to the lifecycle, but not removed when updating 'lifecycleOwner' or destroying the view.
I've tested this for my project and it seems to fix the issue. Note: It is only fixed when I set the 'lifecycleOwner' myself:
Without setting it I still get a memory leak notification from LeakCanary. I think this is because of the lifecycleOwner that is being used at line 277. But I'm no expert on that part, so I might be wrong.
https://github.com/skydoves/PowerSpinner/blob/main/powerspinner/src/main/kotlin/com/skydoves/powerspinner/PowerSpinnerView.kt#L277.