Add Create DashApp and create Singlestore Cloud Functions template to spaces #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathts07
force-pushed
the
bharath-templates
branch
from
4e3d5ea to
de0d487
Compare
bharathts07
force-pushed
the
bharath-templates
branch
from
de0d487 to
e137ac3
Compare
kesmit13
reviewed
Nov 8, 2024
| "with open(ca_cert_path, \"wb\") as f:\n", | ||
| " f.write(response.content)\n", | ||
| "\n", | ||
| "sql_connection_string = connection_url.replace(\"singlestoredb\", \"mysql+pymysql\")\n", |
There was a problem hiding this comment.
Why are you pulling out the singlestoredb driver and using pymysql?
There was a problem hiding this comment.
This is a template for dashboards and cloud functions.
%%sql doesnt work in a multi threaded manner, which is why we need to use the sqlalchemy engine with a connection pool for now.
There was a problem hiding this comment.
I still don't understand. Why doesn't SinlgeStoreDB work? PyMySQL has the exact same thread issues that the SingleStoreDB client does.
srinathnarayanan
approved these changes
Nov 8, 2024
|
I will merge and test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
WHY