Add active event
#49
Merged
Add active event
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
requested changes
Nov 8, 2018
|
@szmarczak Updated |
szmarczak
approved these changes
Nov 9, 2018
|
LGTM. |
timgit
changed the title
sindresorhus
requested changes
Dec 25, 2018
|
@sindresorhus Requested changes pushed. |
sindresorhus
changed the title
active event
szmarczak
requested changes
Feb 20, 2019
sindresorhus
approved these changes
Feb 21, 2019
|
Does the dependency on the "events" Node.js package not break browser compatibility? If so, a callback/observable implementation could be an alternative solution, and would be more light-weight. Perhaps this type of change could also be a major version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar in spirit to a proprosal in #41. This doesn't necessitate the use case mentioned in that issue, but it would provide a tool which could be used for that purpose. My motivation for this would be to have a hook into the processing without requiring an external interval to poll a queue instance.