Don't produce URL with "?" alone #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a technical reason why this behavior is problematic for you or is it purely an aesthetic preference? |
|
It is not problematic, just aesthetic preference. |
|
Another concern is duplicate cache. Because the cache is identified by URL, these two URLs "/path?" and "/path" will make the browser (or proxy) to create two caches, even though they point to the same document. It is wasteful. |
sholladay
requested changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
searchParamsis an empty project,kystill produce URL with question mark, like "/path?". It should be without "?".This PR is to fix that.