mtimeMs comparison is broken in node v14.17.0

[gavinaiken]

In node v14.17.0 on Mac OSX Catalina I am seeing an issue where gulp-changed always detects the source file as changed because the target is getting an mtimeMs slightly behind that of the source file when gulp creates it. This problem did not exist in v14.16.1.

The comparison happens here: https://github.com/sindresorhus/gulp-changed/blob/main/index.js#L28 and I am seeing mtimes for example like this:

sourceFile.stat.mtimeMs: 1621590505837.191
targetStat.mtimeMs:  1621590505836.999

Previously the target mtime would be eg 1621590505837 so the two floor comparisons would work fine.

A simple work-around for this is to use floor for the source and ceil for the target, which resolves the issue for me. I will provide a PR with this change.

[sindresorhus]

Thanks for reporting. Please open an issue on the Node.js issue tracker.

[gavinaiken]

OK, will do. Have provided a very simple PR for consideration here too.

[gavinaiken]

It's looking like this problem is due to a change in libuv, based on the discussion in the issue I opened on node. I think this is likely to be much easier to fix here (with the PR I have already put up) than it is going to be over in node / libuv. Thoughts?

[sindresorhus]

I'm happy to add a workaround here in the meantime, but it's always best to try to also fix it at the source.