Broken with Node.js ≥ 13.10.0

[TimothyGu]

Describe the bug

• Node.js version: 13.10.0 or 13.10.1
• OS & version: Linux 5.5.6-1-MANJARO x86_64 GNU/Linux

got.stream does not work with Node.js ≥ 13.10.0. Node.js 13.9.0 works fine.

Actual behavior

When piped into a stream, the receiving stream receives no data.

Expected behavior

When piped into a stream, the receiving stream receives the entire HTTP response.

Code to reproduce

const got = require("got");
got.stream("https://www.github.com/").pipe(process.stdout);
// one can also use stream.pipeline here. Same result.

With Node.js < 13.9.0, output fills the screen. With ≥ 13.10.0, there is no console output.

Checklist

• I have read the documentation.
• I have tried my code with the latest version of Node.js and Got.

[darksabrefr]

Same behavior here but all got is affected not only streams :

const got = require("got");

// ensure no exit before the timer was cleared
const interval = setInterval(() => {}, 60000);

(async () => {
	console.log('step 1');
	const result = await got("https://www.github.com/");
	console.log(result);
	console.log('step 2');
	clearInterval(interval);
})();

This code never throws, exits or output results. It only display step 1 and do nothing more. Before node 13.10.0 it displays results.

[mrGibi]

2 hours of debugging and searching for my mistake... 😄
Same here after upgrading Node to v13.10.1.

[arcanis]

@szmarczak Are there plans to backport the fix into a minor / patch release? This bug is fairly serious. Yarn 2 relies on Got, which causes builds to abort mid-sequence.

[szmarczak]

It's gonna be a patch release. I'm working on this right now.

[szmarczak]

LOL @nodejs messed up!

const {PassThrough, pipeline} = require('stream');
const https = require('https');

const body = new PassThrough();
const request = https.request('https://example.com');

request.once('abort', () => {
	console.log('The request has been aborted');
});

pipeline(
	body,
	request,
	error => {
		console.log(`Pipeline errored: ${!!error}`);
	}
);

body.end();

gives

Pipeline errored: false
The request has been aborted

This is the culprit: https://github.com/nodejs/node/pull/31940/files#diff-eefad5e8051f1634964a3847b691ff84R36

It calls .abort() on every request you make using pipeline.

https://github.com/nxtedition/node/blob/5a55b1df97a1f93c5fb81bf758050d81524ae834/lib/internal/streams/destroy.js#L166

[szmarczak]

nodejs/node#32105

[TimothyGu]

@szmarczak Are you sure pipeline is the issue here? My original example used the plain old .pipe().