Got doesn't throw on leading slashes

[szmarczak]

As per the readme:

Note: Leading slashes in input are disallowed when using this option to enforce consistency and avoid confusion. For example, when the prefix URL is https://example.com/foo and the input is /bar, there's ambiguity whether the resulting URL would become https://example.com/foo/bar or https://example.com/bar. The latter is used by browsers.

But it does not throw:

got/source/normalize-arguments.ts

Lines 303 to 319 in 3c6ca29

	if (is.string(options.url)) {
	options.url = (options.prefixUrl as string) + options.url;
	options.url = options.url.replace(/^unix:/, 'http://$&');
	if (options.searchParams || options.search) {
	options.url = options.url.split('?')[0];
	}
	// @ts-ignore URL is not URL
	options.url = optionsToUrl({
	origin: options.url,
	...options
	});
	} else if (!is.urlInstance(options.url)) {
	// @ts-ignore URL is not URL
	options.url = optionsToUrl({origin: options.prefixUrl as string, ...options});
	}

[azz]

I don't think it should throw if prefixUrl is just an origin:

const myApi = got.extend({ prefixUrl: 'https://api.example.com' });

myApi.get('/things'); // this should be fine as it is not ambiguous.

[szmarczak]

@azz The readme says that the ending / will be added automatically if not present, thus it should throw if the input starts with /.

[azz]

That's what's currently documented but I'm challenging whether that behaviour is appropriate, especially in the case where it is non-ambiguous.

[szmarczak]

The documentation provides a non-ambiguous behavior, which has been intensively discussed. please see #829 and #943 for more information.