Tolerate lack of node_modules when checking if directory is writable
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not return undefined when `node_modules` does not exist but can be created.
coreyfarrell
commented
Nov 18, 2019
Comment on lines
+31
to
+32
| if (!isWritable(nodeModules)) { | ||
| if (fs.existsSync(nodeModules) || !isWritable(path.join(directory))) { |
There was a problem hiding this comment.
Sorry if this is not the wanted style. I can combine the two if statements if desired, I'm not sure what you want for maximum line length or how you want an if conditional split over multiple lines.
|
This would resolve: storybookjs/storybook#8863 |
ndelangen
approved these changes
Nov 18, 2019
|
Could this be moved along if possible 🙇🙇🙇 ? Do the maintainers need help? I'd be happy to assist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not return undefined when
node_modulesdoes not exist but can becreated.
nyc testing found this issue.