Don't report no-process-exit rule in worker threads
#388
Conversation
Rule no-process-exit should enable process.exit() when worker_threads module is required.
test/no-process-exit.js
Outdated
| 'const {workerData, parentPort} = require(\'worker_threads\')\n\nprocess.exit(1);', | ||
| 'import {workerData, parentPort} from \'worker_threads\'\n\nprocess.exit(1);', | ||
| 'import foo from \'worker_threads\'\n\nprocess.exit(1);', | ||
| '' |
There was a problem hiding this comment.
this empty code is introduced in #1 , but seems useleess
There was a problem hiding this comment.
I thought it was meant just to make sure the rule doesn't trigger by nothing. I just left it as is but I can remove it if needed.
There was a problem hiding this comment.
Actually, I'm not sure about it, maybe @sindresorhus need review this.
let's keep it unresolved
There was a problem hiding this comment.
Makes sense to me to keep it. Just to be safe. We should really add it to all the rules.
There was a problem hiding this comment.
Ok. I'll restore it later today. Should I do it for others here or in a separate PR?
There was a problem hiding this comment.
Doesn't matter. We should add it to all the rules.
|
Just realized some commit came from another PR. Removed it and pushed again. |
sindresorhus
changed the title
no-process-exit rule in worker threads
3 participants
Rule no-process-exit should enable process.exit()
when worker_threads module is required.
Fixes #328
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor