Skip to content

Conversation

@fisker
Copy link
Collaborator

@fisker fisker commented Oct 13, 2025

Fixes #2746

@fisker fisker force-pushed the no-useless-fallback-in-set-constructor branch from b0e6101 to 5d0b5b5 Compare October 13, 2025 07:41
@fisker fisker requested a review from Copilot October 13, 2025 08:56

This comment was marked as resolved.

@fisker fisker force-pushed the no-useless-fallback-in-set-constructor branch from dfdb6c4 to 270aea5 Compare October 18, 2025 09:51
@fisker fisker changed the title Add no-useless-fallback-in-set-constructor rule Add no-useless-collection-argument rule Oct 18, 2025
@fisker fisker marked this pull request as ready for review October 18, 2025 09:58
'new Set([],)',
'new Set( (([])), )',
// Who care?
'new Set(document.all ?? [])',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also on line 71.

@sindresorhus sindresorhus merged commit 2d07c9a into sindresorhus:main Oct 19, 2025
18 checks passed
@fisker fisker deleted the no-useless-fallback-in-set-constructor branch October 19, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule proposal: forbid new Set(foo ?? [])

2 participants