Add no-accessor-recursion rule

[axetroy]

Close #1052

[sindresorhus]

Suggested change

	# Disallow recursive access to this within getter and setter
	# Disallow recursive access to `this` within getters and setters

[sindresorhus]

Suggested change

	description: 'Disallow recursive access to this within getter and setter',
	description: 'Disallow recursive access to `this` within getters and setters.',

[sindresorhus]

Can you rename the test file from .mjs to .js?

[sindresorhus]

You need to regenerate the snapshots npx ava -u.

[axetroy]

There are missing cases for setters, please give a shoot, if it's hard to fix we can ignore.

class Foo{
	set bar() {
		[this.bar] = array;
	}
}

class Foo{
	set bar() {
		({propery: this.bar} = object);
	}
}

class Foo{
	set bar() {
		Object.assign(this, {bar: 1})
	}
}

But this case for getters is common, we should report

class Foo{
	get bar() {
		const {bar} = this;
	}
}

The last case is already supported and tested, the other cases I don't think anyone will write that way.

And they are difficult to detect, Maybe we should ignore it

[fisker]

Not checking shorthand(Not needed), and computed.

[fisker]

@axetroy Handled more cases a17cef9 (#2525), please take a look.

[axetroy]

👍

[fisker]

Do you know how this works in class static initialization blocks? Can you check if we need logic adjustments?

[fisker]

Alright, I found

The this inside a static block refers to the constructor object of the class.

So, I think we need some updates to getClosestFunctionScope.

const foo = {
	get bar() {
		class Foo {
			static {
				this.bar // <- This should not reported.
			}
		}
	}
}

[fisker]

Good job!