Skip to content

Conversation

@Yash-Singh1
Copy link
Contributor

Fixes #1510

@Yash-Singh1 Yash-Singh1 marked this pull request as draft September 6, 2021 03:07
@Yash-Singh1
Copy link
Contributor Author

@Yash-Singh1 Yash-Singh1 marked this pull request as ready for review September 6, 2021 22:10
@sindresorhus
Copy link
Owner

You need to add the configs directory to package.json

@Yash-Singh1
Copy link
Contributor Author

Applied suggestions in b79b233

@AriPerkkio
Copy link
Contributor

Coverage of smoke tests could now be increased.

extends: ['plugin:unicorn/recommended'],

- extends: ['plugin:unicorn/recommended'], 
+ extends: ['plugin:unicorn/all'], 

(It would also be great to include there even the rules which require options but that's out of scope here)

@sindresorhus sindresorhus merged commit a512ad1 into sindresorhus:main Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export an all config

4 participants