Skip to content

Conversation

lukehorvat
Copy link
Contributor

Fixes #97. I implemented @thetutlage's solution here.

@lukehorvat lukehorvat changed the title Different approach to preventing meta events from being emitted Different approach to preventing userland from emitting meta events Jun 5, 2022
@sindresorhus
Copy link
Owner

@lukehorvat Bump :)

@lukehorvat
Copy link
Contributor Author

Sorry, completely forgot to follow up on this... 🤦🏻‍♂️

I pushed a commit adding a finally block to ensure canEmitMetaEvents always gets reverted to false. So I think this should be ready to go now?

@sindresorhus sindresorhus merged commit c07c783 into sindresorhus:main Aug 11, 2022
@sindresorhus
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regresssion in PR#96

2 participants