Skip to content

Conversation

arthur-er
Copy link
Contributor

@arthur-er arthur-er commented Apr 30, 2021

Closes #82

@sindresorhus
Copy link
Owner

Can you add it to all the methods that accept it? See: https://github.com/sindresorhus/emittery/pull/82/files

@arthur-er
Copy link
Contributor Author

Can you add it to all the methods that accept it? See: https://github.com/sindresorhus/emittery/pull/82/files

I'm unsure about how to add the tests. But I added the type into the other methods

@sindresorhus
Copy link
Owner

They need to be tested for this to be merged.

@arthur-er
Copy link
Contributor Author

They need to be tested for this to be merged.

Tests added!

@sindresorhus
Copy link
Owner

sindresorhus commented May 2, 2021

Tests are failing. Please always run npm test locally before pushing changes.

@arthur-er
Copy link
Contributor Author

arthur-er commented May 3, 2021

I'm getting issues with pEvent compatibility, the emitter in pEvent don't expect the emitter methods to receive an array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants